Feat: async load prompt#83
Open
Mahhheshh (Mahhheshh) wants to merge 2 commits intobraintrustdata:mainfrom
Open
Feat: async load prompt#83Mahhheshh (Mahhheshh) wants to merge 2 commits intobraintrustdata:mainfrom
Mahhheshh (Mahhheshh) wants to merge 2 commits intobraintrustdata:mainfrom
Conversation
Mahhheshh (Mahhheshh)
force-pushed
the
fix/28
branch
from
f5c2671 to
7214726
Compare
Member
|
I'm going to spend a little more time thinking about this API, so not going to immediately open this. Need to make sure this is the right thing to work on. |
ankur's work from braintrustdata/braintrust-sdk-javascript#771 Co-authored-by: Mahhheshh <100200105+Mahhheshh@users.noreply.github.com>
Mahhheshh (Mahhheshh)
force-pushed
the
fix/28
branch
from
7214726 to
4916c1d
Compare
| "otel": ["opentelemetry-api", "opentelemetry-sdk", "opentelemetry-exporter-otlp-proto-http"], | ||
| # orjson is not compatible with PyPy, so we exclude it for that platform | ||
| "performance": ["orjson; platform_python_implementation != 'PyPy'"], | ||
| "performance": ["orjson; platform_python_implementation != 'PyPy'", "aiohttp"], |
Contributor
Author
There was a problem hiding this comment.
moved this from install_requires to extras_require.
comment: braintrustdata/braintrust-sdk-javascript#771 (comment)
| HTTP_REQUEST_THREAD_POOL, | ||
| lambda: _state._prompt_cache.get( | ||
| slug, | ||
| version=str(version) if version else "latest", |
Contributor
Author
There was a problem hiding this comment.
Should this be just "latest"?
Contributor
Author
|
force push after resolving merge conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #28
The base for this PR was worked upon by Ankur in (braintrustdata/braintrust-sdk-javascript#771)
I have adapted with the changes of
load_prompt.working upon the tests; would require some guidance